Additional changes to the gladstone PR. #77977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…badi/roslyn into removeProjectAnalyzer
…ence-packages build 20250331.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.617601 -> To Version 10.0.618101
This can screw up the comparison to the check where we compare the timestamp of each input in any set to the last build start time. Works around dotnet/project-system#9651
With the addition of the 60+ roslyn-analyzer projects, the load time for Roslyn.sln has suffered. While we investigate ways to improve the load time, this solution filter allows you to open the pre-merge set of projects.
This can screw up the comparison to the check where we compare the timestamp of each input in any set to the last build start time. Works around dotnet/project-system#9651
…tDictionary (dotnet#77959) Measured changing lazyFilePathToRelatedDocumentIds by the following approaches during a load of Roslyn.sln: 1) ImmutableDictionary (current) 2) Standard Dictionary with a lock around it's usage 3) ConcurrentDictionary Stopwatch time spent in GetDocumentIdsWithFilePath (avg of 3 runs) (lower is better) 1: 8.6 sec 2: 9.7 sec 3: 7.8 sec ETL % of CPU time in GetDocumentIdsWithFilePath spent in ComputeDocumentIdsWithFilePath (higher is better) 1: 96.6% 2: 80.3% 3: 97.5% ETL % of allocations in GetDocumentIdsWithFilePath from ComputeDocumentIdsWithFilePath (higher is better) 1: 26.1% 2: 87.2% 3: 50.0%
Currently 'draft' as this depends on TypeScript having moved entirely to LSP pull diagnostics. TS pr to move them off of us is here: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/623063
…tnet#77969) This reverts commit ffd763a, reversing changes made to ff34293. We need TypeScript to flow into the d18initial branch first.
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
CyrusNajmabadi
changed the base branch from
main
to
dev/maprospe/gladstone-spike
CyrusNajmabadi
merged commit 44d16e9
into
dotnet:dev/maprospe/gladstone-spike
5 checks passed
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.