Move Copilot context provider to EA.Copilot and handler to LanguageServer #77973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
genlu
force-pushed
the
contextProviderRefac
branch
2 times, most recently
from
c76dbb9 to
f37ff26
Compare
dibarbet
reviewed
Apr 3, 2025
src/Features/ExternalAccess/Copilot/Internal/Completion/CSharpContextProviderService.cs
Outdated
Show resolved
Hide resolved
| Microsoft.CodeAnalysis.ExternalAccess.Copilot.Completion.TraitItem.TraitItem(Microsoft.CodeAnalysis.ExternalAccess.Copilot.Completion.TraitItem! original) -> void | ||
| Microsoft.CodeAnalysis.ExternalAccess.Copilot.Completion.TraitItem.TraitItem(string! name, string! value, int importance = 0) -> void | ||
| Microsoft.CodeAnalysis.ExternalAccess.Copilot.Completion.TraitItem.Value.get -> string! | ||
| Microsoft.CodeAnalysis.ExternalAccess.Copilot.Completion.TraitItem.Value.init -> void |
There was a problem hiding this comment.
should we remove the EA for the handler itself? though that may break the recent prerelease...
There was a problem hiding this comment.
I'm inclined to keep it here a bit longer, at least until we have a release with the new APIs
...ageServer/LanguageServer/Handler/CopilotCompletion/CopilotCompletionResolveContextHandler.cs
Outdated
Show resolved
Hide resolved
3 tasks
genlu
force-pushed
the
contextProviderRefac
branch
2 times, most recently
from
e8529a1 to
4cf9923
Compare
genlu
force-pushed
the
contextProviderRefac
branch
from
4cf9923 to
2fa53c0
Compare
dibarbet
approved these changes
Apr 10, 2025
This was referenced Apr 19, 2025
|
Just got to see the backport. I have a lot of thoughts ont he code here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required changes
C# ext: dotnet/vscode-csharp#8126
vs.converstaions: https://devdiv.visualstudio.com/DevDiv/_git/VisualStudio.Conversations/pullrequest/625059