Update RuntimeHelpers.Await rules
#77957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules now clarify the extensibility point we're looking to establish with the runtime for `Await` helpers. Generally speaking, these are just ordinary methods that a user is free to call, so there's no issue with us using them for subtypes of `Task`, since the user could write that themselves and the runtime will have to handle it.
ghost
added
Area-Compilers
untriaged
jcouv
reviewed
Apr 2, 2025
jcouv
reviewed
Apr 2, 2025
|
@jcouv @RikkiGibson @agocke please review |
RikkiGibson
reviewed
Apr 10, 2025
| 2. There is an identity or implicit reference conversion from `E` to the type of `P`. | ||
| 4. Otherwise, if `Mi` has a generic arity of 1 with type param `Tm`, all of the following must be true, or `Mi` is removed: | ||
| 1. The return type is `Tm` | ||
| 2. There is an identity or implicit reference conversion from `E`'s unsubstituted definition to `P` |
There was a problem hiding this comment.
I'm unsure what "E's unsubstituted definition" means. Is it something like, if E is Task<C> then its unsubstituted definition is Task<T>?
There was a problem hiding this comment.
Correct. I also struggled to find a better wording, but couldn't come up with one.
RikkiGibson
reviewed
Apr 10, 2025
RikkiGibson
reviewed
Apr 10, 2025
agocke
reviewed
Apr 11, 2025
jcouv
reviewed
Apr 29, 2025
|
@jcouv @RikkiGibson for another look please; I removed hoisted local, as per dotnet/runtime#112918. |
RikkiGibson
approved these changes
Apr 29, 2025
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules now clarify the extensibility point we're looking to establish with the runtime for
Awaithelpers. Generally speaking, these are just ordinary methods that a user is free to call, so there's no issue with us using them for subtypes ofTask, since the user could write that themselves and the runtime will have to handle it.