Remove rip-cord feature flags #77738
Conversation
ghost
added
Area-IDE
untriaged
| public bool EnableDiagnosticsInSourceGeneratedFiles | ||
| => _globalOptions.GetOption(SolutionCrawlerOptionsStorage.EnableDiagnosticsInSourceGeneratedFiles) ?? | ||
| _globalOptions.GetOption(SolutionCrawlerOptionsStorage.EnableDiagnosticsInSourceGeneratedFilesFeatureFlag); | ||
| => globalOptions.GetOption(SolutionCrawlerOptionsStorage.EnableDiagnosticsInSourceGeneratedFiles); |
There was a problem hiding this comment.
So I think we might need a bigger approach for ripcord settings like this, since I think this PR as written puts is in a worse place. temporarily. Right now it's obvious this was a feature flag rollout, but once we delete it then this setting lives around even longer...and it's not obvious anymore (unless you have the context for it) that the only reason the setting exists was for a ripcord -- no user should need to change it otherwise.
I'd say we should be deleting these switches (and the commit async and document outline flags) entirely, or add some sort of TODO on them, or check in a docs file listing the flags and the expected removal date. Because otherwise this will still live around until somebody notices them "eventually".
There was a problem hiding this comment.
i'm ok pulling the flags entirely.
CyrusNajmabadi
merged commit 2817f33
into
dotnet:release/dev17.15
These feature flags existed so we could use control tower to remotely disable something if we ran into a problem post release. We haven't run into problems here, so we can just remove those flags.