Bump BCL references to 9.0 #76890
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,37 +47,37 @@ | |
| --> | ||
| <PropertyGroup> | ||
| <SystemCommandLineVersion>2.0.0-beta4.24528.1</SystemCommandLineVersion> | ||
| <SystemCompositionVersion>9.0.0</SystemCompositionVersion> | ||
|
There was a problem hiding this comment. Is it possible at all to deploy missing dependencies as part of F5/integration tests? IIRC we have this project for it - https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Setup.Dependencies/Roslyn.VisualStudio.Setup.Dependencies.csproj#L21 |
||
| <SystemConfigurationConfigurationManagerVersion>9.0.0</SystemConfigurationConfigurationManagerVersion> | ||
| <SystemDiagnosticsEventLogVersion>9.0.0</SystemDiagnosticsEventLogVersion> | ||
| <SystemCollectionsImmutableVersion>9.0.0</SystemCollectionsImmutableVersion> | ||
| <SystemComponentModelCompositionVersion>9.0.0</SystemComponentModelCompositionVersion> | ||
| <SystemDiagnosticsDiagnosticSourceVersion>9.0.0</SystemDiagnosticsDiagnosticSourceVersion> | ||
| <SystemIOHashingVersion>9.0.0</SystemIOHashingVersion> | ||
| <SystemIOPipelinesVersion>9.0.0</SystemIOPipelinesVersion> | ||
| <SystemReflectionMetadataVersion>9.0.0</SystemReflectionMetadataVersion> | ||
| <SystemResourcesExtensionsVersion>9.0.0</SystemResourcesExtensionsVersion> | ||
| <SystemSecurityCryptographyProtectedDataVersion>9.0.0</SystemSecurityCryptographyProtectedDataVersion> | ||
| <SystemSecurityPermissionsVersion>9.0.0</SystemSecurityPermissionsVersion> | ||
| <SystemTextEncodingsWebVersion>9.0.0</SystemTextEncodingsWebVersion> | ||
| <!-- Note: When updating SystemTextJsonVersion ensure that the version is no higher than what is used by MSBuild in VS (would lead to NGEN failures on insertion). --> | ||
| <SystemTextJsonVersion>9.0.0</SystemTextJsonVersion> | ||
| <SystemThreadingTasksDataflowVersion>9.0.0</SystemThreadingTasksDataflowVersion> | ||
| <SystemWindowsExtensionsVersion>9.0.0</SystemWindowsExtensionsVersion> | ||
| <MicrosoftBclAsyncInterfacesVersion>9.0.0</MicrosoftBclAsyncInterfacesVersion> | ||
| <MicrosoftCodeAnalysisAnalyzersVersion>3.11.0</MicrosoftCodeAnalysisAnalyzersVersion> | ||
| <MicrosoftCodeAnalysisAnalyzerUtilitiesVersion>3.3.0</MicrosoftCodeAnalysisAnalyzerUtilitiesVersion> | ||
| <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23468.1</MicrosoftCodeAnalysisNetAnalyzersVersion> | ||
| <MicrosoftDiaSymReaderVersion>2.0.0</MicrosoftDiaSymReaderVersion> | ||
| <MicrosoftExtensionsConfigurationVersion>9.0.0</MicrosoftExtensionsConfigurationVersion> | ||
| <MicrosoftExtensionsDependencyInjectionVersion>9.0.0</MicrosoftExtensionsDependencyInjectionVersion> | ||
| <MicrosoftExtensionsFileSystemGlobbingVersion>8.0.0</MicrosoftExtensionsFileSystemGlobbingVersion> | ||
| <MicrosoftExtensionsLoggingVersion>9.0.0</MicrosoftExtensionsLoggingVersion> | ||
| <MicrosoftExtensionsLoggingAbstractionsVersion>9.0.0</MicrosoftExtensionsLoggingAbstractionsVersion> | ||
| <MicrosoftExtensionsLoggingConsoleVersion>9.0.0</MicrosoftExtensionsLoggingConsoleVersion> | ||
| <MicrosoftExtensionsOptionsConfigurationExtensionVersion>8.0.0</MicrosoftExtensionsOptionsConfigurationExtensionVersion> | ||
| <MicrosoftExtensionsOptionsVersion>9.0.0</MicrosoftExtensionsOptionsVersion> | ||
| <MicrosoftExtensionsPrimitivesVersion>9.0.0</MicrosoftExtensionsPrimitivesVersion> | ||
| <MicrosoftVSSDKBuildToolsVersion>17.9.3137-preview3</MicrosoftVSSDKBuildToolsVersion> | ||
| <vswhereVersion>2.4.1</vswhereVersion> | ||
| <!-- | ||
|
|
@@ -90,7 +90,7 @@ | |
| <NewtonsoftJsonVersion>13.0.3</NewtonsoftJsonVersion> | ||
| <SystemIdentityModelTokensJwtVersion>6.34.0</SystemIdentityModelTokensJwtVersion> | ||
| <!-- TODO: remove https://github.com/dotnet/roslyn/issues/71827 --> | ||
JoeRobich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <MicrosoftDotNetXliffTasksVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">9.0.0-beta.25065.2</MicrosoftDotNetXliffTasksVersion> | ||
| <MicrosoftIdentityClientVersion>4.61.3</MicrosoftIdentityClientVersion> | ||
| <SystemIdentityModelTokensJwtVersion>6.34.0</SystemIdentityModelTokensJwtVersion> | ||
| </PropertyGroup> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -27,6 +27,8 @@ | |||||
| The version targeted is only used for build time, since we use MSBuildLocator to discover the proper version at runtime. | ||||||
| --> | ||||||
| <_MsbuildVersion>17.3.4</_MsbuildVersion> | ||||||
| <!-- S.C.I 9.0 no longer supports .NET 6 --> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> | ||||||
|
There was a problem hiding this comment. @jasonmalinowski Would we want to pin the BuildHost at S.C.I 8.0.0 until we are ready to bump the tfm? There was a problem hiding this comment. Generally we should be bumping the BuildHost TFM "as late as possible". Once we merge the other PR that makes the library netstandard2.0, somebody could theoretically try to use MSBuildWorkspace in a 6.0 app...but if the BuildHost only runs on 8.0 or later you end up creating an implicit version limitation there. That is of course not to say that we should bend backwards to support older versions -- but if we can do a minimal amount of work to keep stuff older, that might be easier than dealing the inevitable bugs people file when old versions don't work. I think setting this property seems easiest; frankly I'm kinda surprised we added such a property in the first place. I'd propose changing the comment though since I'm sure other package upgrades will depend on this than just System.Collections.Immutable. There was a problem hiding this comment. And oh: I imagine this is easier to set this than it is to pin versions and deal with the special problems that creates. There was a problem hiding this comment. ah ok, I was afraid the package wasn't shipping with netstandard or net6.0 builds but it still has netstardard2.0 |
||||||
| </PropertyGroup> | ||||||
| <ItemGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'"> | ||||||
| <PackageReference Include="Microsoft.Build" VersionOverride="$(_MsbuildVersion)" ExcludeAssets="Runtime" PrivateAssets="All" /> | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.