Partial properties: duplicate membersByName before merging accessors
#74969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
cston
commented
Aug 31, 2024
| membersByName = new Dictionary<ReadOnlyMemory<char>, ImmutableArray<Symbol>>(membersByName, ReadOnlyMemoryOfCharComparer.Instance); | ||
| } | ||
|
|
||
| DuplicateMembersByNameIfCached(ref membersByName); |
There was a problem hiding this comment.
Previously, membersByName was modified in mergeAccessors before duplicating.
RikkiGibson
reviewed
Sep 3, 2024
| membersByName[name] = FixPartialMember(membersByName[name], prevProperty, currentProperty); | ||
| } | ||
|
|
||
| void mergeAccessors(ref Dictionary<ReadOnlyMemory<char>, ImmutableArray<Symbol>> membersByName, ReadOnlyMemory<char> name, SourcePropertyAccessorSymbol? currentAccessor, SourcePropertyAccessorSymbol? prevAccessor) | ||
| void mergeAccessors(ref Dictionary<ReadOnlyMemory<char>, ImmutableArray<Symbol>> membersByName, SourcePropertyAccessorSymbol? currentAccessor, SourcePropertyAccessorSymbol? prevAccessor) |
There was a problem hiding this comment.
It also seems like this function could take membersByName by value instead.
RikkiGibson
approved these changes
Sep 3, 2024
333fred
approved these changes
Sep 3, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate
membersByNamedictionary before modifying inmergeAccessorsif the dictionary is cached.Note, the potential race condition is speculative. I'm not aware of a reported issue, and I have not been able to create a test that hits an issue here.
Relates to test plan #73090