Fix false positives for Dispose rules #2348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generated code Fixes dotnet#2306
Fixes one of the scenarios from dotnet#2245
…ons within conditional expression We assume that out argument of an invocation returning false within a conditional branch is invalid and does not require disposing. Fixes another scenario in dotnet#2245
|
Merging this in as we want to start testing the latest drop from this branch for 2.9.2 release. I'll address any PR feedback with a follow-up change. |
This was referenced Apr 16, 2019
dotpaul
reviewed
Apr 17, 2019
| operation.Parameter.RefKind == RefKind.Out && | ||
| operation.Parent is IInvocationOperation invocation && | ||
| invocation.TargetMethod.ReturnType.SpecialType == SpecialType.System_Boolean) | ||
| { |
There was a problem hiding this comment.
Can't think of anything of the top of my head, but this seems like a heuristic to keep an eye on in the future. Otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2306: CA2213 (DisposableFieldsShouldBeDisposed)
Fixes #2245 (2 scenarios): CA2000 (DisposeObjectsBeforeLosingScope)
outarguments of invocations within conditional expression. We assume that anoutargument of an invocation returning false within a conditional branch is invalid and does not require disposing.