Integrate OpenCover and codecov.io for code coverage #1616
Conversation
Workaround for dotnet/project-system#2374 Workaround for dotnet/roslyn#25041
sharwell
force-pushed
the
codecov
branch
6 times, most recently
from
1e649c4 to
cd6bc2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
=========================================
Coverage ? 92.94%
=========================================
Files ? 711
Lines ? 112995
Branches ? 3197
=========================================
Hits ? 105021
Misses ? 7244
Partials ? 730
Continue to review full report at Codecov.
|
sharwell
changed the title
sharwell
force-pushed
the
codecov
branch
4 times, most recently
from
ab33b46 to
9a8fc46
Compare
sharwell
changed the title
sharwell
changed the title
| @@ -10,5 +14,119 @@ | |||
| <EmbeddedResource Update="**\*.resx" GenerateSource="true" /> | |||
| </ItemGroup> | |||
|
|
|||
| <Import Project="$(RepoToolsetDir)Imports.targets" Condition="Exists('$(RepoToolsetDir)Imports.targets')" /> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
This adds significant amount of infrastructure code, which smells like something that should probably belong to RepoToolset, instead of individual repos? Are we planning to eventually move this code over?
@tmat is probably the correct person to review and comment on these changes.
There was a problem hiding this comment.
It needs to get cleaned up, and the core functionality needs to be incorporated into RepoToolset.
I should read the PR description properly :-). Are we planning to merge in this change and revert once the functionality is in RepoToolset or wait for a RepoToolset package with this functionality before cleaning and merging this PR?
There was a problem hiding this comment.
I should read the PR description properly :-). Are we planning to merge in this change and revert once the functionality is in RepoToolset or wait for a RepoToolset package with this functionality before cleaning and merging this PR?
I would like to get it merged so we can get a better understanding of how this configuration of codecov.io works with our development process. Any tweaks we make can be included in dotnet/roslyn-tools#170 before it gets merged.
This pull request demonstrates the work required to complete #1614. It needs to get cleaned up, and the core functionality needs to be incorporated into RepoToolset.
This pull request builds on #1608.