[ClickOnce] Fix for GB18030 character issues in ClickOnce publishing #9062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ning51
approved these changes
Jul 24, 2023
sujitnayak
changed the title
sujitnayak
changed the title
John-Hart
approved these changes
Jul 24, 2023
|
Already fixed in msbuild:main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
AB#1852036
AB#1852046
Context
Projects with GB18030 characters fail during ClickOnce publishing of .NET FX and VSTO Addin-in projects.
Changes Made
GB1830 characters in PUA block get escaped by XmlReader.Create(string, ...) because it treats the string argument as a URI. This can cause publishing failure b/c the paths become invalid. We now use StreamReader to load the file and pass that to XmlReader.Create.
Testing
Stepped through code to confirm the fixes made.
CTI team is validating the fixes.
Notes