[vs17.2] Update the build tools

[JanKrivanek]

Fixes broken 17.2 build

Context

vs17.2 Signing Validation is failing (https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7772042&view=logs&j=b11b921d-8982-5bb3-754b-b114d42fd804&t=cdcedd1f-8008-523f-9da1-cc35fbfef9a3):

##[error](NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) {"$id":"1","innerException":null,"message":"The resource RoslynTools.MSBuild.17.0.nupkg for package 'RoslynTools.MSBuild 17.0' doesn't exist. Did you mean roslyntools.msbuild.17.0.0.nupkg?","typeName":"Microsoft.VisualStudio.Services.NuGet.WebApi.Exceptions.PackageSubresourceNotFoundException, Microsoft.VisualStudio.Services.NuGet.WebApi","typeKey":"PackageSubresourceNotFoundException","errorCode":0,"eventId":3000}

So updating to 17.2.1 - to align the build tooling with vs17.4 branch

[ghost]

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

[Forgind]

It more sounds like it wants 17.0.0 rather than 17.2.1...what made you jump to 17.2.1? (I don't think it'll break things, but to be consistent, I'm guessing we'd increase the version with every branch, and that seems like extra work if 17.0 works.)

[JanKrivanek]

It more sounds like it wants 17.0.0 rather than 17.2.1...what made you jump to 17.2.1? (I don't think it'll break things, but to be consistent, I'm guessing we'd increase the version with every branch, and that seems like extra work if 17.0 works.)

Signing validation was failing with the 17.0.0
I could either try bump version by version (spamming the PR queue), or I just decided resorting to the next version that's proved to be working - as it's used by vs17.4 branch. I decided for the later in spirit of quicker unblocking.

[Forgind]

I think this should work.

I may have stated my question poorly. I saw that it failed to find 17.0, but the error message said "The resource RoslynTools.MSBuild.17.0.nupkg...doesn't exist. Did you mean roslyntools.msbuild.17.0.0.nupkg?", which made me think that 17.0.0 does exist, in which case the important change here is from major.minor to major.minor.build, not from 17.0 to 17.2. If that's the case, 17.0.0 might work where 17.2 wouldn't.

It ultimately doesn't matter too much, since 17.2.1 is known to work 🙂

[JanKrivanek]

I think this should work.

I may have stated my question poorly. I saw that it failed to find 17.0, but the error message said "The resource RoslynTools.MSBuild.17.0.nupkg...doesn't exist. Did you mean roslyntools.msbuild.17.0.0.nupkg?", which made me think that 17.0.0 does exist, in which case the important change here is from major.minor to major.minor.build, not from 17.0 to 17.2. If that's the case, 17.0.0 might work where 17.2 wouldn't.

It ultimately doesn't matter too much, since 17.2.1 is known to work 🙂

Aaaah - gotcha! Good point!
Well - I'll reserve it as fallback :-) now trying with the setup that we have on vs17.4