[vs17.2] Expliciltly require matching version of VS for signing validation step #8758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rainersigwald
approved these changes
May 15, 2023
Forgind
approved these changes
May 15, 2023
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - failing signing validation step of vs17.2 build
Context
vs17.2 Signing Validation is failing (https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7763789&view=logs&j=b11b921d-8982-5bb3-754b-b114d42fd804&t=cdcedd1f-8008-523f-9da1-cc35fbfef9a3):
Inspecting the arcade scripts - the version used is comming from https://github.com/dotnet/msbuild/blob/vs17.2/eng/common/sdk-task.ps1#L67 and can be overwritten via 'xcopy-msbuild' in our global.json.
We're already doing so on main and other release branches.