Enable prebuilt detection #8678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mmitche
commented
Apr 18, 2023
mmitche
commented
- Baseline a few dependencies until msbuild targets net8.0, or an arcade fix comes in
- Add SBRP dependencies (with subscription) and source build tags
- Baseline a few dependencies until msbuild targets net8.0, or an arcade fix comes in - Add SBRP dependencies (with subscription) and source build tags Update SBRP
27 tasks
JanKrivanek
approved these changes
Apr 19, 2023
| @@ -1,5 +1,22 @@ | |||
| <UsageData> | |||
| <IgnorePatterns> | |||
| <UsagePattern IdentityGlob="*/*" /> | |||
| <UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" /> | |||
There was a problem hiding this comment.
I was expecting the net7 targeting pack to be reported as a prebuilt. Do you know why it isn't?
There was a problem hiding this comment.
Because of this?
Line 6 in 8326396
There was a problem hiding this comment.
Oh sure, the 7.0 SDK is carrying the targeting pack it needs. Thanks for pointing that out.
MichaelSimons
approved these changes
Apr 19, 2023
|
I'm going to change this PR to simply baseline anything built in 7.0 |
|
@MichaelSimons Revised the fix to baseline all 7.0* |
JanKrivanek
reviewed
Apr 20, 2023
Comment on lines
+35
to
+38
| <UsagePattern IdentityGlob="Microsoft.Build.Tasks.Git/*1.1.0-beta-20206-02*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceLink.AzureRepos.Git/*1.1.0-beta-20206-02*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceLink.Common/*1.1.0-beta-20206-02*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceLink.GitHub/*1.1.0-beta-20206-02*" /> |
There was a problem hiding this comment.
@mmitche Aren't those too specific?
We are seeing errors complaining on those in the arcade update PR (https://github.com/dotnet/msbuild/pull/8658/checks?check_run_id=12897668061):
.packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.23219.1/tools/SourceBuild/AfterSourceBuild.proj(65,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 4 new packages used not in baseline! See report at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml for more information. Package IDs are:
Microsoft.Build.Tasks.Git.1.1.0-beta-21423-02
Microsoft.SourceLink.AzureRepos.Git.1.1.0-beta-21423-02
Microsoft.SourceLink.Common.1.1.0-beta-21423-02
Microsoft.SourceLink.GitHub.1.1.0-beta-21423-02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.