Skip to content

Add tsa config file to enable validation pipeline #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

marcpopMSFT
Copy link
Member

Context

MSBuild had been added to the code validation pipeline but was missing the tsa config file. Per the instructions here and after talking to Matt, adding this file

Changes Made

Added a tsa config file by copying from SDK

Testing

Not sure how to test this. I pushed an internal build but the checks didn't run as I'm told they run nightly in a separate pipeline.

Notes

Validation pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=2157183&view=results

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - in case you are sure with having TsaPublish and not TsaOnboard.

The linked arcade help points to runtime sdl-tsa-vars.config that has both. I could only find some description burried in the arcade history https://github.com/dotnet/arcade/blob/ece8fe4f40e0eb788d0ae82472281002f064812a/eng/common/sdl/execute-all-sdl-tools.ps1#L17 - which seems to suggest TsaPublish should be set to onboard, and TsaPublish should be only used after that. But hopefully this confusing statefulness is already not applicable

Per the documentation and Matt, adding the onboard flag.
@marcpopMSFT
Copy link
Member Author

@JanKrivanek it's not clear to me if that flag is required or not. I checked and nearly every other repo does set that flag to true (except for sdk and installer) so I went ahead and added it. I double checked with Matt and he suggested adding it as well. This PR is ready to go in whenever.

@JanKrivanek JanKrivanek added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 17, 2023
@JanKrivanek
Copy link
Member

Thanks @marcpopMSFT!

It would be nice if arcade had that param documented (since they refer to that in sample config). Thanks for making extra effort to attempt to extract some info and convention.

This is good to go.

@JaynieBai JaynieBai merged commit ac3f5ad into main Apr 21, 2023
@JaynieBai JaynieBai deleted the marcpopMSFT-addtsaconfigfile branch April 21, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants