Fix flaky test CanShutdownServerProcess #8638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Apr 5, 2023
Co-authored-by: Rainer Sigwald <[email protected]>
ladipro
approved these changes
Apr 5, 2023
Co-authored-by: Rainer Sigwald <[email protected]>
|
/azp run |
rokonec
added
the
merge-when-branch-open
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8631
Context
We have got him!
There was eluding low freq flaky test. It was caused by race condition between finishing build server client and server releasing its
I am busymutex.Changes Made
Wait and retry when it was detected busy for 500 ms.
Clean additional logging from test.
Testing
Local, PR