Skip to content

Clarify what .default means #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

Forgind
Copy link
Contributor

@Forgind Forgind commented Apr 3, 2023

.default (in MSBuild code) followed an earlier spec that referred to it as and omitted some details. This clarifies the meaning of .default.

Fixes #

Context

Changes Made

Testing

Notes

.default (in MSBuild code) followed an earlier spec that referred to it as <default> and omitted some details. This clarifies the meaning of .default.
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be ok with just updating all <default> to .default in the doc directly.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 3, 2023
@JaynieBai JaynieBai merged commit 37bf098 into main Apr 4, 2023
@JaynieBai JaynieBai deleted the clarify-default-target-in-static-graph branch April 4, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants