LiveLogger v2 #8619
Merged
LiveLogger v2 #8619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect and fix console resize Detect and limit max nodes by console height
Closed
This will give us a new hook to ensure folks are on the newest bits and not the prior version.
Now accepts `-tl` which means `-tl:auto`, as well as `-tl:true` and `-tl:false`, allowing overriding the detection.
I was noticing a bunch of nodes that seemed "stuck" on targets that shouldn't take a long time--turns out they were done with that + idle but never got marked as such so they kept counting up confusingly.
Use variation selector to try to display as a symbol instead of an emoji.
This is more responsive and keeps the counter on screen at all times at the cost of giving up any hope of understanding what's going on within the restore.
rainersigwald
approved these changes
Apr 10, 2023
| /// <summary> | ||
| /// The indentation to use for all build output. | ||
| /// </summary> | ||
| private const string Indentation = " "; |
There was a problem hiding this comment.
What's the motivation for this? I think I'd rather have two extra characters of space.
There was a problem hiding this comment.
I think we wanted this for an easier-to-read multiline output (both "project done" and warnings/errors) because it's easier to tell on which terminal line a logical line starts. Without this the output looks like the proverbial wall of text. Very subjective and I don't feel strongly about it.
ladipro
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8481, fixes #8464, fixes #8463, fixes #8460, fixes #8458, fixes #8456, fixes #8430, fixes #8370, fixes #8392
Context
We have decided to change the LiveLogger UX. Instead of the "full screen" or "takes-over-the-screen-buffer" interactive experience, the goal is a more conventional logger with a node-centric live view and no interactivity.
Changes Made
Re-implemented LiveLogger based on the https://www.github.com/rainersigwald/tortillachip prototype. Since the visual design is not yet finalized, the strings are still hardcoded in source files.
Testing
Existing and newly introduced tests. Manual smoke test.
Notes
LiveLogger.cswas completely rewritten so please look at the new content instead of the diff.Here are some of the differences compared to v1:
Example build gifs