Localize response-file-used message #8608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Mar 30, 2023
Forgind
approved these changes
Mar 31, 2023
Forgind
added
the
merge-when-branch-open
KirillOsenkov
added a commit
to KirillOsenkov/MSBuildStructuredLog
that referenced
this pull request
Apr 4, 2023
See dotnet/msbuild#8608 When this string ships in production MSBuild, we will regenerate Strings.json against those dlls and will get the correct localized strings. For now they are all English. Generated by running the ResourcesGenerator tool against a locally build MSBuild containing the new string.
|
Added support for this string to the binlog viewer too: FYI @JanKrivanek |
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Apr 13, 2023
In dotnet#8608 I introduced a new string for this, but it's redundant with the one we already had that we only used to log to the console. Dropping the "log directly to console" approach because we now (18 years later) have deferred messages, the engine API that someone didn't want to add.
JaynieBai
pushed a commit
that referenced
this pull request
Apr 17, 2023
In #8608 I introduced a new string for this, but it's redundant with the one we already had that we only used to log to the console. Dropping the "log directly to console" approach because we now (18 years later) have deferred messages, the engine API that someone didn't want to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message was in hardcoded English, but all the other deferred messages are localized.