-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix static graph restore functionality for the bootstrap #8488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static graph restore functionality for the bootstrap #8488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this failed checks. I haven't looked into why. |
At a glance, seems like an Arcade issue? Windows Full shows:
And a few of the others show:
(note, although the word "bootstrap" is in there, this seems like an Arcade thing, not the MSBuild bootstrap?) |
Oh, hm. I just saw a bunch of failing tests and assumed there was some problem but didn't expect arcade. Why should that cause trouble with this PR but not others? |
Not sure. Can you kick a retry to confirm if it's somehow these changes? |
Ah nvm, this is definitely my changes. I'll investigate more as this isn't repro'ing locally for me. |
7bef8f6
to
d7aa063
Compare
fa138fe
to
bd15f80
Compare
bd15f80
to
9900994
Compare
9900994
to
e589eb7
Compare
Remove unnecessary message
Today the bootstrap doesn't have
NuGet.RestoreEx.targets
(orNuGet.Build.Tasks.Console.exe
even), so it falls back to the "regular" restore. This change brings in those bits via theNuGet.Build.Tasks.Console
package.