Skip to content

Fix static graph restore functionality for the bootstrap #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Feb 22, 2023

Today the bootstrap doesn't have NuGet.RestoreEx.targets (or NuGet.Build.Tasks.Console.exe even), so it falls back to the "regular" restore. This change brings in those bits via the NuGet.Build.Tasks.Console package.

rainersigwald
rainersigwald previously approved these changes Feb 22, 2023
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Feb 22, 2023
@Forgind
Copy link
Contributor

Forgind commented Feb 23, 2023

Note that this failed checks.

I haven't looked into why.

@dfederm
Copy link
Contributor Author

dfederm commented Feb 23, 2023

Note that this failed checks.

I haven't looked into why.

At a glance, seems like an Arcade issue?

Windows Full shows:

D:\a\1\s.dotnet\sdk\7.0.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(267,5): error NETSDK1004: Assets file 'D:\a\1\s\artifacts\obj\Microsoft.Build\project.assets.json' not found. Run a NuGet package restore to generate this file. [D:\a\1\s\src\Build\Microsoft.Build.csproj::TargetFramework=net472]

And a few of the others show:

##[error]stage1\bin\bootstrap\net7.0\MSBuild\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) An error occurred trying to start process 'D:\a\1\s\stage1\bin\bootstrap\dotnet' with working directory 'D:\a\1\s'. The system cannot find the file specified.

(note, although the word "bootstrap" is in there, this seems like an Arcade thing, not the MSBuild bootstrap?)

@Forgind
Copy link
Contributor

Forgind commented Feb 23, 2023

Oh, hm. I just saw a bunch of failing tests and assumed there was some problem but didn't expect arcade. Why should that cause trouble with this PR but not others?

@dfederm
Copy link
Contributor Author

dfederm commented Feb 23, 2023

Oh, hm. I just saw a bunch of failing tests and assumed there was some problem but didn't expect arcade. Why should that cause trouble with this PR but not others?

Not sure. Can you kick a retry to confirm if it's somehow these changes?

@dfederm
Copy link
Contributor Author

dfederm commented Feb 23, 2023

Ah nvm, this is definitely my changes. I'll investigate more as this isn't repro'ing locally for me.

@dfederm dfederm force-pushed the fix-bootstrap-staticgraphrestore branch from 7bef8f6 to d7aa063 Compare February 23, 2023 23:14
@rainersigwald rainersigwald dismissed their stale review February 23, 2023 23:19

want to rereview after it works

@dfederm dfederm force-pushed the fix-bootstrap-staticgraphrestore branch 3 times, most recently from fa138fe to bd15f80 Compare February 23, 2023 23:54
@Forgind Forgind removed the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Feb 24, 2023
@dfederm dfederm marked this pull request as draft March 6, 2023 17:58
@dfederm dfederm force-pushed the fix-bootstrap-staticgraphrestore branch from bd15f80 to 9900994 Compare April 5, 2023 19:22
@dfederm dfederm force-pushed the fix-bootstrap-staticgraphrestore branch from 9900994 to e589eb7 Compare April 5, 2023 23:37
@dfederm dfederm marked this pull request as ready for review April 6, 2023 00:12
@rainersigwald rainersigwald self-assigned this Apr 6, 2023
@rainersigwald rainersigwald merged commit 5fbc295 into dotnet:main Apr 7, 2023
@dfederm dfederm deleted the fix-bootstrap-staticgraphrestore branch April 7, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants