Support SkipNonexistentTargets in project reference target protocol
#8330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyShepelev
commented
Jan 20, 2023
|
Is there a specific use-case for this? I see a theoretical one, but I'm not aware of anything in the typical p2p protocol which uses |
Forgind
added
the
Area: Static Graph
DmitriyShepelev
force-pushed
the
skip-nonexistent-targets
branch
from
b4ea87a to
ac66585
Compare
|
dfederm
reviewed
Jan 25, 2023
dfederm
reviewed
Jan 25, 2023
dfederm
reviewed
Jan 25, 2023
…pNonexistentTargets='true'` to `GetTargetFrameworksWithPlatformForSingleTargetFramework`
DmitriyShepelev
force-pushed
the
skip-nonexistent-targets
branch
from
47fd30c to
11cb710
Compare
dfederm
reviewed
Jan 26, 2023
dfederm
reviewed
Jan 26, 2023
…uild` and address documentation
rokonec
approved these changes
Jan 30, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8330 in repo dotnet/msbuild |
dfederm
approved these changes
Jan 30, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rokonec
added
the
merge-when-branch-open
|
@DmitriyShepelev Please help resolve the conflicts |
JaynieBai
pushed a commit
that referenced
this pull request
Apr 19, 2023
Update documentation given the merge of #8249, #8257, and #8330. --------- Co-authored-by: Rainer Sigwald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4252
Context
This PR extracts the relevant logic from the closed #5297, which adds support for the
SkipNonexistentTargetsmetadatum on theProjectReferenceTargetsitem:If
SkipNonexistentTargetsistrue, then any targets inTargetsare skipped if they're nonexistent.SkipNonexistentTargetscannot be added toProjectReferenceTargetsitems whoseTargetscontain.defaultor.projectReferenceTargetsOrDefaultTargets, which represent the default targets and targets specified on theProjectReferenceitem (with fallback to default targets if none are specified), respectively.Changes Made
GetTargetListsfilters out skippable nonexistent targets on referenced projects.BuildResults to ensure that correspondingBuildRequestConfigurations on the build manager node have set project targets if the build manager node created a configuration based on a request from an external node but hadn't received a result (since the project may not have been loaded locally and thus the project targets would be unknown).SkipNonexistentTargets='true'toGetTargetFrameworkssince in the non-graph case it is added to the relevant MSBuild task.Testing
UTs and manual testing with
/graphand/graph /isolate(the latter run withoutrestorebeing called due to #6856) on the erroring repos I saw when testing #8249.Notes
Addressing this since it came up when testing #8249.
cc @dfederm