Skip to content

Add opt-in for default channel registrations check #11751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Apr 21, 2025

@JaynieBai JaynieBai self-assigned this Apr 21, 2025
@JaynieBai JaynieBai marked this pull request as ready for review April 22, 2025 09:26
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 09:26
@JaynieBai JaynieBai requested a review from a team as a code owner April 22, 2025 09:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces an opt-in mechanism to enforce default channel registrations during the build. Key changes include:

  • Adding a new boolean parameter "requireDefaultChannels" to the post-build template
  • Forwarding the parameter through to the sdk-task invocation
  • Enabling the parameter in the .vsts-dotnet pipeline configuration

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/common/core-templates/post-build/post-build.yml Adds a new boolean parameter and passes it to the build command
.vsts-dotnet.yml Sets "requireDefaultChannels" to true to enforce the check in pipeline
Files not reviewed (1)
  • eng/common/post-build/publish-using-darc.ps1: Language not supported

@JaynieBai JaynieBai marked this pull request as draft April 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Build publishing - Opt-in into strict checking of default branch registration
1 participant