Set IDE0005 (Remove unnecessary using directives) severity to Warning #11643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s IDE0005 diagnostic configuration by changing its severity to Warning and removing unnecessary using directives from various unit test files. The changes help clean up the codebase and avoid clutter from unused imports.
- Change IDE0005 severity from None to Warning.
- Remove a number of unused using directives from multiple test files.
- Update tests to add a NoWarn for IDE0005 when GenerateDocumentationFile is false.
Reviewed Changes
Copilot reviewed 369 out of 370 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Build.OM.UnitTests/Instance/ProjectTargetInstance_Tests.cs | Removed the unnecessary "using System.Xml;" |
| src/Build.OM.UnitTests/Instance/ProjectOnErrorInstance_Tests.cs | Removed unnecessary "using System.IO;" and "using System.Xml;" directives |
| src/Build.OM.UnitTests/Instance/ProjectItemInstance_Tests.cs | Removed several unused using directives including "using System.Xml;", "using System.IO;", and others |
| src/Build.OM.UnitTests/Instance/ProjectInstance_Tests.cs | Removed "using System.Xml;" |
| src/Build.OM.UnitTests/Definition/ProtectImports_Tests.cs | Removed "using System.Xml;" |
| src/Build.OM.UnitTests/Definition/ProjectProperty_Tests.cs | Removed "using System.Xml;" |
| src/Build.OM.UnitTests/Definition/ProjectMetadata_Tests.cs | Removed "using System.Xml;" |
| src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs | Removed "using System.Xml;" and "using Xunit.NetCore.Extensions;" |
| src/Build.OM.UnitTests/Definition/ProjectItemDefinition_Tests.cs | Removed "using Microsoft.Build.Shared;" |
| src/Build.OM.UnitTests/Definition/EditingElementsReferencedByOrReferences_Tests.cs | Removed "using System.IO;" and "using System.Xml;" directives |
| src/Build.OM.UnitTests/Definition/DefinitionEditing_Tests.cs | Removed "using System.Xml;" and "using Microsoft.Build.Shared;" directives |
| src/Build.OM.UnitTests/Construction/SolutionFile_Tests.cs | Removed several unnecessary using directives including "using System;", "using System.Collections;", "using System.IO;", "using System.Text;" |
| src/Build.OM.UnitTests/Construction/ProjectTaskElement_Tests.cs | Removed "using System.IO;" and "using System.Xml;" directives |
| src/Build.OM.UnitTests/Construction/ProjectTargetElement_Tests.cs | Removed "using Microsoft.Build.Shared;" |
| src/Build.OM.UnitTests/Construction/ProjectRootElement_Tests.cs | Removed several unused using directives including "using System.Reflection;", "Shouldly", "Microsoft.Build.Framework", and "Xunit.NetCore.Extensions" |
| src/Build.OM.UnitTests/Construction/ProjectPropertyGroupElement_Tests.cs | Removed "using System.IO;" and "using System.Xml;" directives |
| src/Build.OM.UnitTests/Construction/ProjectItemGroupElement_tests.cs | Removed "using System.IO;" and "using System.Xml;" directives |
| src/Build.OM.UnitTests/Construction/ProjectFormatting_Tests.cs | Removed "using System.Xml;" |
| src/Build.OM.UnitTests/Construction/ConstructionEditing_Tests.cs | Removed "using System.Xml;" |
Files not reviewed (1)
- .editorconfig: Language not supported
YuliiaKovalova
approved these changes
Mar 31, 2025
JanProvaznik
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10159
Context
some of the imports are unnecessary, due to the severity set to none: dotnet_diagnostic.IDE0005.severity = none in the .editorconfig file
Changes Made
<NoWarn>$(NoWarn);IDE0005</NoWarn>to ignore IDE0005The reason is Compiler does not report unused imports when XML doc comments are disabled roslyn#41640