Skip to content

add telemetry e2e test, address code quality issues #11602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

JanProvaznik
Copy link
Member

Fixes #11485 #11506

Context

#11481

Changes Made

moving files, renaming, ading docs

Testing

adds a e2e test for node telemetry by capturing it with an ActivityListener

Notes

@JanProvaznik JanProvaznik changed the base branch from main to vs17.14 March 17, 2025 13:50
@YuliiaKovalova YuliiaKovalova requested a review from AR-May March 24, 2025 13:10
Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just couple of very minor suggestions.

@JanProvaznik JanProvaznik changed the base branch from vs17.14 to main March 28, 2025 15:04
@JanProvaznik JanProvaznik enabled auto-merge (squash) March 28, 2025 15:07
@JanProvaznik JanProvaznik disabled auto-merge March 28, 2025 15:07
@JanProvaznik JanProvaznik enabled auto-merge (squash) March 28, 2025 15:07
@JanProvaznik JanProvaznik merged commit 248a0de into dotnet:main Mar 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add e2e test for node telemetry
3 participants