null check logging mechanism before logging glob failure #11537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surayya-MS
approved these changes
Mar 4, 2025
|
Could you please fulfill the ticket requirement "let's at least turn nullable analysis on for this method"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11528
Context
We added logging for intermittent glob failures in #11211. For that a logging mechanism is needed. But it is possible to pass null logging mechanism to the GetFileList method, which is what happens in the bug.
Changes Made
add a null check for logging mechanism to skip logging in case of null
Testing
this occurs intermittently :(
Notes