Skip to content

Add the check on version bump up #11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

GangWang01
Copy link
Member

Add the check on version bump up.

@YuliiaKovalova
Copy link
Member

I assume it's already implemented.

@JanProvaznik
Copy link
Member

@YuliiaKovalova it's not for 17.8

@JanProvaznik JanProvaznik reopened this Apr 2, 2025
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@YuliiaKovalova
Copy link
Member

@YuliiaKovalova it's not for 17.8

But do we need it for 17.8?

@JanProvaznik
Copy link
Member

JanProvaznik commented Apr 2, 2025

it's useful for catching missing version bumps before merge, same as in other branches, not sure why it was missing here
and the consequence of missing a bump would be failure in official build, which is annoying but fixable by a post-hoc bump

@YuliiaKovalova YuliiaKovalova merged commit b46a62a into dotnet:vs17.8 Apr 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants