Skip to content

Option to avoid "fixing" \ in new TaskItem() #11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Option to avoid "fixing" \ in new TaskItem() #11120

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1802372
check if it is filepath
maridematte Dec 10, 2024
6d2c46a
Note to self: avoid coding when very tired
maridematte Dec 11, 2024
8460601
Keep old constructor
maridematte Dec 11, 2024
2ef5117
Removed default value
maridematte Dec 13, 2024
23a7761
Fix build error
maridematte Dec 13, 2024
862c796
Updated comments from PR suggestions
maridematte Dec 13, 2024
e4474a6
File was not saved with all the changes -_-
maridematte Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/Utilities/TaskItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public sealed class TaskItem :
/// Default constructor -- do not use.
/// </summary>
/// <remarks>
/// This constructor exists only so that the type is COM-creatable. Prefer <see cref="TaskItem(string)"/>.
/// This constructor exists only so that the type is COM-creatable. Prefer <see cref="TaskItem(string, bool)"/>.
/// </remarks>
[EditorBrowsable(EditorBrowsableState.Never)]
public TaskItem()
Expand All @@ -77,12 +77,29 @@ public TaskItem()
/// </summary>
/// <comments>Assumes the itemspec passed in is escaped.</comments>
/// <param name="itemSpec">The item-spec string.</param>
public TaskItem(string itemSpec)
: this(itemSpec, treatAsFilePath: true) { }

/// <summary>
/// This constructor creates a new task item, given the item spec.
/// </summary>
/// <comments>
/// Assumes the itemspec passed in is escaped.
/// If <see name="treatAsFilePath" /> is set to <see langword="true" />, the value in <see name="itemSpec" />
/// will be fixed up as path by having backslashes replaced with slashes.
/// </comments>
/// <param name="itemSpec">The item-spec string.</param>
/// <param name="treatAsFilePath">
/// Specifies whether or not to treat the value in <see name="itemSpec" />
/// as a file path and attempt to normalize it. Defaults to <see langword="true" />.
/// </param>
public TaskItem(
string itemSpec)
string itemSpec,
bool treatAsFilePath)
{
ErrorUtilities.VerifyThrowArgumentNull(itemSpec);

_itemSpec = FileUtilities.FixFilePath(itemSpec);
_itemSpec = treatAsFilePath ? FileUtilities.FixFilePath(itemSpec) : itemSpec;
}

/// <summary>
Expand Down