ToolTask UseUtf8Encoding value of 'true' is equal to 'always' #10949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10907
Context
The
UseUtf8Encoding
property of theExec
task and otherToolTask
derived tasks should accepttrue
and equivalent toalways
.Changes Made
ToolTask
doesn't validate or interpret theUseUtf8Encoding
property. The value of the property is passed to and interpreted byEncodingUtilities.BatchFileEncoding()
.EncodingUtilities
was modified to add a const string forTRUE
and theBatchFileEncoding()
method was modified to handleTRUE
andALWAYS
the same.Testing
Created a unit test that compares the returns for
ALWAYS
andTRUE
, confirmed that the unit test failed, modified the code, and confirmed the unit test passes.Tested on Windows.
Notes
On non-Windows platforms the
UseUtf8Encoding
property has no effect.