Error handling for failures on registered actions for Custom Checks #10914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Oct 31, 2024
JanKrivanek
suggested changes
Oct 31, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
suggested changes
Nov 8, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckCentralContext.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10522
Context
Second PR for that issue. This PR covers the cases in a Custom Check where there is an exception while registering actions, and when running said actions.
Since actions are individuals, we do not deregister the whole analyzer when one fails.
It has been decided to expose these errors are warnings instead to not break the build where they show up.
Changes Made
Added some try catch statements so errors do not break builds. Messages have been added to each case for more detail as we do not preserve anything else from the exception.
Testing
Reenabled unit test and added the previously commented out cases.
Notes