fix path combine #280
Closed
fix path combine #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, looks good |
|
I would appreciate it if the PR or an issue described the problem that is being addressed by the PR. I assume that it is a cross plat fix dealing with path separators on various platforms. Other than that the change looks like a good one. Thanks for taking care of this. |
|
Next time i'll add the reason. Anyway is right @KevinRansom, this is a code cleanup to fix cross plat directory separators, and easier align openfsharp and visualfsharp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code cleanup to fix cross plat directory separators, and easier align openfsharp and visualfsharp.
Edit by kevinr.