Skip to content

Fix a small mistake in String.init's docs #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

bbatsov
Copy link
Contributor

@bbatsov bbatsov commented Apr 3, 2025

Description

There's no "mapping" parameter. I'm guessing this was a copy/paste mistake.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

It doesn't seem I can do this.

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

There's no "mapping" parameter. I'm guessing this was a copy/paste mistake.
Copy link
Contributor

github-actions bot commented Apr 3, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 3, 2025
@T-Gro
Copy link
Member

T-Gro commented Apr 3, 2025

Thanks for spotting this. This was likely a copy-paste mistake or a refactoring not applied to comment.
I have added the label to skip mandatory release notes.

@T-Gro T-Gro enabled auto-merge (squash) April 3, 2025 07:22
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@T-Gro T-Gro merged commit 0566db0 into dotnet:main Apr 3, 2025
33 of 34 checks passed
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants