Skip to content

Fix delegate with option parameter #18385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2025
Merged

Fix delegate with option parameter #18385

merged 7 commits into from
Mar 17, 2025

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented Mar 15, 2025 •
edited
Loading

Description

Fix MethodDefNotFound when compiling code invoking delegate with option parameter

Fixes #5171

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@ijklam ijklam requested a review from a team as a code owner March 15, 2025 12:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

psfinaki
psfinaki approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing an old and annoying bug!

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 17, 2025
@psfinaki psfinaki merged commit a58a47e into dotnet:main Mar 17, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional parameters for delegates
3 participants
@ijklam @psfinaki @abonie