xUnit tests - improve assembly fixture #18381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
reviewed
Mar 17, 2025
T-Gro
approved these changes
Mar 17, 2025
abonie
approved these changes
Mar 17, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
Co-authored-by: Tomas Grosup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per xUnit v2 samples it is better to do custom assembly fixture initialization in the Executor.
The problem with previous code was that any exceptions in custom TestFramework constructor can cause silent failures: the tests still run but the customizations don't work.