Skip to content

Tests: redirect log to test output #18324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Feb 17, 2025

Description

In the test suite log was originally an alias for printfn:

    let log format = printfn format

My previous changes made its output to essentially go nowhere. There are however many log calls in the tests. As it is essentially printfn, it should print to the output of the respective test case, just like printfn.

Fixes:
result of
image
can be seen in test output:

image

@majocha majocha requested a review from a team as a code owner February 17, 2025 23:45
Copy link
Contributor

✅ No release notes required

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@psfinaki
Copy link
Member

/azp run

1 similar comment
@psfinaki
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro enabled auto-merge (squash) February 25, 2025 12:30
@T-Gro T-Gro merged commit c281bd0 into dotnet:main Feb 25, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants