Skip to content

Add missing project reference from FSharpSuite to fsc project #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 4, 2025

FSharpSuite uses fsc by .exe invocation.

This project reference ensures that fsc is invalidated when compiler changes are present.
That way, running tests from VS will not risk using stale fsc.exe executable.

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Feb 4, 2025
@T-Gro T-Gro requested a review from a team as a code owner February 4, 2025 13:08
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro
Copy link
Member Author

T-Gro commented Feb 4, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit 5ef029b into main Feb 5, 2025
33 checks passed
@T-Gro T-Gro deleted the fsharpsuite-add-projectreference-fcs branch February 10, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants