Skip to content

src/Compiler/TypedTree/TypedTreePickle.fs and refactored. #18203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

progressive-galib
Copy link
Contributor

@progressive-galib progressive-galib commented Jan 6, 2025

Description

"#if" directive around nullness removed from src/Compiler/TypedTree/TypedTreePickle.fs and refactored.

Related: #18061 (partially addresses)

Checklist

  • Release notes entry updated: in
    docs/release-notes/.FSharp.Compiler.Service/9.0.200.md,

"#if" directive around nullness removed from src/Compiler/TypedTree/TypedTreePickle.fs and refactored.

Fixes dotnet#18061 (partially)
@progressive-galib progressive-galib requested a review from a team as a code owner January 6, 2025 12:16
Copy link
Contributor

github-actions bot commented Jan 6, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki
Copy link
Member

psfinaki commented Jan 6, 2025

Note, I am editing your PR descriptions in other to not close the related ticket accidentally. GitHub has some voodoo which automatically closes tickets if it detects a sentence like "Fixes #XYZ".

@progressive-galib
Copy link
Contributor Author

@T-Gro T-Gro merged commit 73b8cbb into dotnet:main Jan 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants