Skip to content

Handle some flaky ProjectAnalysisTests cases #18200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Jan 3, 2025

Description

Test cases utilizing Project25 do not like to run concurrently with each other. Probably because of the XmlProvider here:

module internal Project25 =
let fileName1 = Path.ChangeExtension(getTemporaryFileName (), ".fs")
let base2 = getTemporaryFileName ()
let dllName = Path.ChangeExtension(base2, ".dll")
let projFileName = Path.ChangeExtension(base2, ".fsproj")
let fileSource1 = """
module TypeProviderTests
open FSharp.Data
type Project = XmlProvider<"<root><value>1</value><value>3</value></root>">

I verified locally by running some iterations that marking the affected test cases with RunTestCasesInSequence resolves the problem.

@majocha majocha requested a review from a team as a code owner January 3, 2025 13:40
Copy link
Contributor

github-actions bot commented Jan 3, 2025

✅ No release notes required

@majocha majocha closed this Jan 3, 2025
@majocha majocha reopened this Jan 3, 2025
@T-Gro T-Gro enabled auto-merge (squash) January 6, 2025 10:30
@psfinaki
Copy link
Member

psfinaki commented Jan 6, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

psfinaki commented Jan 6, 2025

This PR is particularly unlucky...

@majocha
Copy link
Contributor Author

majocha commented Jan 6, 2025

Ah, this particular failure is unrelated but a genuine bug. I'll sort it out.

@T-Gro T-Gro merged commit ded0349 into dotnet:main Jan 6, 2025
33 checks passed
@psfinaki
Copy link
Member

psfinaki commented Jan 7, 2025

Thanks @majocha for your continuous interest 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants