Skip to content

Improve directory attribute refactor - Break up PR #18161 - Part 1 #18195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2025
Merged

Improve directory attribute refactor - Break up PR #18161 - Part 1 #18195

merged 3 commits into from
Jan 7, 2025

Conversation

KevinRansom
Copy link
Member

This breaks up the directory attribute refactor, which is enormous.

This inital PR contains the test framework code changes.
And 1 quite large folder of test cases that use baselines a fair amount.

/cc @T-Gro

@KevinRansom KevinRansom requested a review from a team as a code owner January 3, 2025 00:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

✅ No release notes required

@KevinRansom KevinRansom force-pushed the ImproveDirectoryAttribute.Refactor branch from e0b845d to e2b0db7 Compare January 3, 2025 00:06
T-Gro
T-Gro approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please post an assurance that the number of tests executed is the same or higher?

@KevinRansom KevinRansom force-pushed the ImproveDirectoryAttribute.Refactor branch from 5a026a0 to 60bfdd0 Compare January 6, 2025 23:55
@KevinRansom KevinRansom force-pushed the ImproveDirectoryAttribute.Refactor branch from 60bfdd0 to 966733f Compare January 7, 2025 01:14
@KevinRansom
Copy link
Member Author

image

psfinaki
psfinaki approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice and very helpful, thanks!

@psfinaki
Copy link
Member

psfinaki commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit 6ce0691 into dotnet:main Jan 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @psfinaki @T-Gro