Skip to content

Fix Internal error when analysing incomplete inherit member #17905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 24, 2024
Merged

Fix Internal error when analysing incomplete inherit member #17905

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
479b185
Internal error when analysing incomplete inherit member
edgarfgp Oct 21, 2024
7f2c43f
release notes
edgarfgp Oct 21, 2024
7bfae49
release notes
edgarfgp Oct 21, 2024
c2b1793
update syntax tree tests
edgarfgp Oct 21, 2024
ad268dd
Merge branch 'fix-17902' of github.com:edgarfgp/fsharp into fix-17902
edgarfgp Oct 21, 2024
f1e1d37
update baselines
edgarfgp Oct 21, 2024
4f7c57c
Update src/Compiler/Service/ServiceParseTreeWalk.fs
edgarfgp Oct 21, 2024
cad5c53
Update src/Compiler/Driver/GraphChecking/FileContentMapping.fs
edgarfgp Oct 21, 2024
6e8b469
Update src/Compiler/Service/ServiceParsedInputOps.fs
edgarfgp Oct 21, 2024
797ef28
Update src/Compiler/Service/ServiceParsedInputOps.fs
edgarfgp Oct 21, 2024
80bd70d
update salsa tests
edgarfgp Oct 21, 2024
888df51
try to debug the test using CI
edgarfgp Oct 22, 2024
8430ba2
Fix tests?
psfinaki Oct 23, 2024
01775fa
Merge branch 'main' into fix-17902
edgarfgp Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* Ensure `frameworkTcImportsCache` mutations are thread-safe. ([PR #17795](https://github.com/dotnet/fsharp/pull/17795))
* Fix concurrency issue in `ILPreTypeDefImpl` ([PR #17812](https://github.com/dotnet/fsharp/pull/17812))
* Fix nullness inference for member val and other OO scenarios ([PR #17845](https://github.com/dotnet/fsharp/pull/17845))
* Fix internal error when analyzing incomplete inherit member ([PR #17905](https://github.com/dotnet/fsharp/pull/17905))


### Added
* Deprecate places where `seq` can be omitted. ([Language suggestion #1033](https://github.com/fsharp/fslang-suggestions/issues/1033), [PR #17772](https://github.com/dotnet/fsharp/pull/17772))
Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/SyntaxTree/SyntaxTree.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type SynLongIdent =

member this.Range =
match this with
| SynLongIdent([], _, _) -> failwith "rangeOfLidwd"
| SynLongIdent([], _, _) -> Range.Zero
| SynLongIdent([ id ], [], _) -> id.idRange
| SynLongIdent([ id ], [ m ], _) -> unionRanges id.idRange m
| SynLongIdent(h :: t, [], _) -> unionRanges h.idRange (List.last t).idRange
Expand Down
12 changes: 12 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/ErrorMessages/ClassesTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,18 @@ type Class() =
(Error 961, Line 5, Col 5, Line 5, Col 12, "This 'inherit' declaration specifies the inherited type but no arguments. Consider supplying arguments, e.g. 'inherit BaseType(args)'.")
(Error 946, Line 5, Col 13, Line 5, Col 15, "Cannot inherit from interface type. Use interface ... with instead.")
]

[<Fact>]
let ``This 'inherit' declaration specifies the inherited type but no arguments. Type name cannot be empty.`` () =
Fsx """
type Class() =
inherit
"""
|> typecheck
|> shouldFail
|> withDiagnostics [
(Error 3159, Line 3, Col 5, Line 3, Col 12, "Type name cannot be empty.")
]

[<Fact>]
let ``The types System.ValueType, System.Enum, System.Delegate, System.MulticastDelegate and System.Array cannot be used as super types in an object expression or class.`` () =
Expand Down
Loading