Add StartImmediate to MailboxProcessor
#14931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmitc
force-pushed
the
add-start-immediate-to-mailbox-processor
branch
from
ddfc233 to
673d6fa
Compare
bmitc
commented
Aug 1, 2023
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/MailboxProcessorType.fs
Show resolved
Hide resolved
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/MailboxProcessorType.fs
Show resolved
Hide resolved
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/MailboxProcessorType.fs
Outdated
Show resolved
Hide resolved
Merged
|
Converting to draft for now. Let us know when you feel like it's ready for review. |
|
It is ready for review, which is why I converted it from draft to ready for review a week or two ago. I have been waiting for review and was planning on pinging on it today. The feature is implemented, has a test, and I added the signatures and documentation in the |
|
@bmitc alright, I will take a look on this tomorrow - thanks! |
|
Sounds good! Thank you! |
psfinaki
approved these changes
Aug 16, 2023
vzarytovskii
approved these changes
Aug 17, 2023
|
Thanks all for the help, discussion, review, and merge! 🎉 |
jwosty
pushed a commit
to jwosty/fsharp
that referenced
this pull request
Aug 18, 2023
* Add `StartImmediate` static and instance members to `MailboxProcessor` * Remove unused `Microsoft.FSharp.Collections` declaration * Add test for `MailboxProcessor.StartImmediate` * Rename test to corrected, intended name and "fix" test * Update baseline tests * Slight update to documentation * Fix baseline tests file * Add additional commentary to test
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F# language suggestion: fsharp/fslang-suggestions#997
Original PR by @xloggr: #11515
This PR implements both a static and instance
StartImmediatemethod toMailboxProcessorto start aMailboxProcessoron the current thread. Normally,Startwill start theMailboxProcessoron the thread pool, but theStartImmediatemethod ensures that theMailboxProcessorstarts on the same thread as the one that calls it. Effectively,MailboxProcessor.StartandMailboxProcessor.StartImmediatemap toAsync.StartandAsync.StartImmediate, respectively.This is useful for situations in which you want to force the
MailboxProcessorto start on a given thread or even run on a single thread throughout its lifetime. For example, aMailboxProcessormay be desired to wrap some unmanaged state, such as a window or some communication session that is not thread safe, and this is not currently possible withMailboxProcessor.Start. To start aMailboxProcessoron a specific thread, simply create that thread and then callMailboxProcessor.StartImmediateon it.Thanks goes to @xloggr for the original suggestion and PR! This PR basically just takes that PR and adds a test and the documentation for
StartImmediate.