Always run on the latest Runtime #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this approach |
JoeRobich
force-pushed
the
run-on-latest
branch
2 times, most recently
from
7f6bd16 to
cc17cf1
Compare
sharwell
reviewed
May 31, 2020
JoeRobich
force-pushed
the
run-on-latest
branch
6 times, most recently
from
527b5f2 to
5940a5c
Compare
|
There was an issue running on 3.0.1xx previews that did not allow 2.x apps to rollforward. Fixed in dotnet/sdk#3542 |
RikkiGibson
reviewed
Jun 1, 2020
| @@ -1,10 +1,13 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.0</TargetFramework> | |||
| <TargetFramework>netcoreapp2.1</TargetFramework> | |||
There was a problem hiding this comment.
did we mean to roll this back?
There was a problem hiding this comment.
Yeah, since we are rolling forward I wanted running the unit tests to behave the same a running dotnet-format.
There was a problem hiding this comment.
the roll forward should allow this to work without issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative fix to the move to netcoreapp3.1, we could always run on the latest installed runtime. We were already rolling forward in cases when the requested runtime was not installed.