Skip to content

Enhance GetETagPropertyName method to handle ETag lookup in both entity and base types #35520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

rezaghadimim
Copy link
Contributor

@rezaghadimim rezaghadimim commented Jan 23, 2025

Enhance GetETagPropertyName method to handle ETag lookup in both entity and base types

  • Added test to cover this scenario and ensure proper functionality

Fixes #35336

Please check whether the PR fulfills these requirements

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

…ty and base types

- Added test to cover this scenario and ensure proper functionality
@rezaghadimim rezaghadimim requested a review from a team as a code owner January 23, 2025 13:46
@SamMonoRT SamMonoRT requested a review from Copilot January 23, 2025 20:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@SamMonoRT
Copy link
Member

@rezaghadimim - the test failures seem related

@rezaghadimim
Copy link
Contributor Author

@rezaghadimim - the test failures seem related

Please run it again as I don't think the error is related to the code. If possible, run the second issue again too. I've seen the following errors:
Wait-CosmosDbEmulator: The emulator failed to reach Running status within 360 seconds

@AndriySvyryd AndriySvyryd merged commit 49e724a into dotnet:main Jan 25, 2025
7 checks passed
@AndriySvyryd
Copy link
Member

Thanks for your contribution!

@rezaghadimim rezaghadimim deleted the etag_for_derived_entities branch January 25, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EF Core for Cosmos DB does not support ETag for derived entities
3 participants