-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Remove invalid versions #9441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid versions #9441
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -338,7 +338,6 @@ | |
"11-21h2-e", | ||
"10-21h2-e-lts", | ||
"10-21h2-iot-lts", | ||
"10-20h2-e-lts", | ||
"10-1809-e-lts", | ||
"10-1607-e-lts" | ||
], | ||
|
@@ -393,11 +392,9 @@ | |
"x86" | ||
], | ||
"supported-versions": [ | ||
"23H2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to https://mcr.microsoft.com/en-us/product/windows/servercore and https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle there was never a release of 23H2 or 2012. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And besides https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle stating that 1607 is only Semi-Anual and released on Nano Server, whereas 2016 is the only Long-Term on Server Core: https://mcr.microsoft.com/en-us/product/windows/servercore shows that it's instead handled like the Server-Core case with 2019 and 1809: So in my opinion, https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle should be fixed to be like this: If 1607 and 1809 are considered LTSC as well, we should update the EOL dates on https://endoflife.date/windows-server-core as well to show they are still maintained (as shown by the image tags on MCR). As of now, both are considered EOL while the LTSC variants are supported: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Server 2012: https://learn.microsoft.com/en-us/lifecycle/products/windows-server-2012 Containers started with 2016, so the container-related lifecycle page is providing a partial view of Windows Server lifecycle. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But since there are no images available, there is nothing to have support for 🤔 Or did there exist a non-containered installation option for 2012? In that case, I will re-add it here and have EoL.dates updated. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I found https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/hh846313(v=vs.85) so I missed to add 2012 to EoL.date. Will have a PR there and fix it here tomorrow once in office. |
||
"2022", | ||
"2019", | ||
"2016", | ||
"2012" | ||
"2016" | ||
], | ||
"unsupported-versions": [ | ||
"20H2", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -316,11 +316,9 @@ | |
"x86" | ||
], | ||
"supported-versions": [ | ||
"23H2", | ||
"2022", | ||
"2019", | ||
"2016", | ||
"2012" | ||
"2016" | ||
] | ||
} | ||
] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -294,7 +294,6 @@ | |
"x86" | ||
], | ||
"supported-versions": [ | ||
"23H2", | ||
"2022", | ||
"2019", | ||
"2016" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows 10 20H2 was only a semi-anual version and never a LTS. Therefore there was also no information on EndOfLife.date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Not sure what happened there. Likely a copy/paste error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
10-20h2-e
and10-20h2-2
be added to the unsupported list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10-20h2-e and 10-20h2-w are already on the unsupported list. Not sure what you mean by 10-20h2-2.