Fix DAM attributes in ValidationAttributeCache to include PublicConstructors #62656
+372
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Validations source generator was emitting IL2075 warnings because the
GetValidationAttributes
method callsType.GetConstructors()
but the Type parameters only hadDynamicallyAccessedMemberTypes.PublicProperties
annotations.The warning was:
Root Cause
In
ValidationsGenerator.Emitter.cs
, theValidationAttributeCache.GetValidationAttributes
method and related types usedDynamicallyAccessedMemberTypes.PublicProperties
but the generated code also callsGetConstructors()
to handle record scenarios where validation attributes may be on constructor parameters.Changes Made
Updated the
DynamicallyAccessedMembers
attributes in 4 locations to include bothPublicProperties | PublicConstructors
:CacheKey
record property annotationGetValidationAttributes
method parameter annotationGeneratedValidatablePropertyInfo
constructor parameter annotationGeneratedValidatablePropertyInfo.ContainingType
property annotationThis ensures the Type parameters have the correct annotations that match their actual usage pattern of accessing both properties (via
GetProperty
) and constructors (viaGetConstructors
).Testing
Fixes #62655.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.