Skip to content

Don't change Arcade's default of XUnitRunnerVisualStudioVersion #62250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 4, 2025

@wtgodbe @captainsafia @ilonatommy If this PR got green, please verify if this fixes the issue, to avoid #62244

Fixes #62223.

@Youssef1313 Youssef1313 requested review from wtgodbe and a team as code owners June 4, 2025 20:28
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 4, 2025
@Youssef1313 Youssef1313 mentioned this pull request Jun 4, 2025
@wtgodbe
Copy link
Member

wtgodbe commented Jun 4, 2025

Looks like we've got some tests still using net462 - might as well update those anyways. I'll push a commit

@wtgodbe
Copy link
Member

wtgodbe commented Jun 4, 2025

Looks like we've got some tests still using net462 - might as well update those anyways. I'll push a commit

Actually, it might take a bit of doing - we should probably stick w/ the SDK update for the short term

@Youssef1313
Copy link
Member Author

@wtgodbe I just pushed a change to use net472. Let's see if it will work.

@ilonatommy
Copy link
Member

@wtgodbe @captainsafia @ilonatommy If this PR got green, please verify if this fixes the issue, to avoid #62244

Tested:

  • CLI
  • VS
  • CI

@ilonatommy ilonatommy requested a review from javiercn June 5, 2025 09:40
@ilonatommy ilonatommy merged commit e232d58 into main Jun 5, 2025
27 checks passed
@ilonatommy ilonatommy deleted the dev/ygerges/xunit-runner-vs-version branch June 5, 2025 10:48
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview6 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests are not running
3 participants