-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Handle langword for see elements #61069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
1c13851
to
b6483d9
Compare
martincostello
commented
May 21, 2025
Handle `<see langword="" />` references in XML documentation as inline code. Resolves dotnet#61042.
Added back by merge/rebase but not needed.
martincostello
added a commit
to martincostello/aspnetcore
that referenced
this pull request
May 22, 2025
Only enable the OpenAPI XML source generator for C#. See dotnet#61069 (comment).
captainsafia
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! A few small nits to polish this up.
src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/CompletenessTests.cs
Show resolved
Hide resolved
captainsafia
pushed a commit
that referenced
this pull request
May 22, 2025
Only enable the OpenAPI XML source generator for C#. See #61069 (comment).
Co-authored-by: Safia Abdalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-minimal
Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
community-contribution
Indicates that the PR has been added by a community member
feature-openapi
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
langword
forsee
elementsHandle
<see langword="value" />
references in XML documentation as inline code.Description
Extract the value from
langword
onsee
references and emit as inline code.For example
<see langword="true" />
becomestrue
.Questions:
seealso
?Do we output verbatim, or map the keywords to something? (e.g. C#null
tonull
but VBNothing
tonull
)Fixes #61042.