Skip to content

Fix DI for the darc vmr get-version command #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2024
Merged

Fix DI for the darc vmr get-version command #4120

merged 6 commits into from
Nov 4, 2024

Conversation

premun
Copy link
Member

@premun premun commented Nov 1, 2024 •
edited
Loading

Fixes dotnet/source-build#4713

  • Fixes the DI registatration for one of the VMR commands which inherits differently than the others
  • Fixes the DI test to generate a test case per each darc operation so that the DI container is not re-used but gets created every time
  • Also fixes flaky test DB setup in tests that has been bugging us for quite some time and have now been somehow more flaky with this PR

@premun premun changed the title Test darc operations one by one Fix DI for the darc vmr get-version command Nov 1, 2024
@premun premun requested a review from dkurepa November 4, 2024 10:28
@premun premun enabled auto-merge (squash) November 4, 2024 13:18
@premun premun merged commit 78cf8ad into dotnet:main Nov 4, 2024
9 checks passed
@premun premun deleted the prvysoky/fix-darc-vmr-get-version branch November 6, 2024 09:09
@MilenaHristova
Copy link
Contributor

rolled out with #4125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkurepa dkurepa dkurepa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMR Build Tagging is Failing
3 participants
@premun @MilenaHristova @dkurepa