Skip to content

Ensure .NET Framework builds pass PEVerify #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 8, 2020
Merged

Ensure .NET Framework builds pass PEVerify #744

merged 7 commits into from
Jul 8, 2020

Conversation

twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Jul 8, 2020 •
edited
Loading

Fixes #734

@twsouthwick twsouthwick mentioned this pull request Jul 8, 2020
Merged
@twsouthwick
Copy link
Member Author

I verified that without the compat flag, the builds fail :) So, hopefully we'll catch any future regressions

@twsouthwick twsouthwick merged commit 88e5088 into dotnet:master Jul 8, 2020
@twsouthwick twsouthwick deleted the peverify branch July 8, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEverify issues using 2.10.0+ NuGet versions of OpenXml
1 participant
@twsouthwick