Skip to content

Implement OpenXmlElementFunctionalExtensions #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ThomasBarnekow
Copy link
Collaborator

This commit implements the OpenXmlElementFunctionalExtensions class and
related unit tests.

Fixes #634.

This commit implements the OpenXmlElementFunctionalExtensions class and
related unit tests.
@twsouthwick
Copy link
Member

This looks great! Can you update the Changelog with this? I'll merge once that's in

twsouthwick
twsouthwick previously approved these changes Feb 7, 2020
@twsouthwick
Copy link
Member

I'm glad this method works without adding so many new constructors. We can explore that option, but if this works, that simplifies the addition of 1000s of new public APIs :)

@ThomasBarnekow
Copy link
Collaborator Author

Just out of curiosity, what exactly would be the problem? If we added new constructors, those would all be implemented in the exact same way, making automatic generation easy. Not sure whether we could replace existing constructors without breaking things.

@ThomasBarnekow
Copy link
Collaborator Author

And, yes, I will update the Changelog.

@ThomasBarnekow
Copy link
Collaborator Author

@twsouthwick, regarding the CHANGELOG, to which version will this be added? 2.11.0 (new feature) or 2.10.1?

@twsouthwick
Copy link
Member

It'll be 2.11.0 - we follow SemVer and this adds new surface area. Any revision (ie 2.10.x) is done as a hotfix-style (see the tag for 2.9.1 where we cherry-picked a fix for .NET Native)

@twsouthwick
Copy link
Member

The issue is just the number of APIs - not necessarily horrible, but it locks it in as we try not to remove APIs for backwards compatibility.

@twsouthwick twsouthwick merged commit 3153a50 into dotnet:master Feb 10, 2020
@ThomasBarnekow ThomasBarnekow deleted the feature/functional-extensions branch December 8, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase flexibility of constructors, e.g., for pure functional transformations
2 participants