Skip to content

Only unload part when saving part if it is not the same element #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

twsouthwick
Copy link
Member

This is fall out from #1760 that removes the loaded part but doesn't check if we're saving an existing root element

Fixes #1771

This is fall out from #1760 that removes the loaded part but doesn't check if we're saving an existing root element
{C91489AB-FF14-4FAD-BA51-35371ADD7E1C} = {7DAF7304-40CC-4180-88A5-9A89DD13C565}
{BB5DF535-E849-42AC-852A-A6D4815347C0} = {3653266D-2C88-4487-8977-839CB3E78A0A}
{5241BCF2-331D-428E-A9C4-F8DF92C8F726} = {A4DF60EB-3AA5-48F0-B4D2-3F94B8E62F03}
{C91489AB-FF14-4FAD-BA51-35371ADD7E1C} = {3653266D-2C88-4487-8977-839CB3E78A0A}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder structure of the sln got messed up at some point. This just puts things back in the order we expect

Copy link

Test Results

    70 files  ± 0      70 suites  ±0   1h 9m 41s ⏱️ + 4m 18s
 2 037 tests + 1   2 034 ✅ + 1   3 💤 ±0  0 ❌ ±0 
32 370 runs  +12  32 334 ✅ +12  36 💤 ±0  0 ❌ ±0 

Results for commit d5c1772. ± Comparison against base commit b515e91.

@twsouthwick twsouthwick enabled auto-merge (squash) November 20, 2024 00:43
@twsouthwick twsouthwick merged commit 1e6ebc9 into main Nov 20, 2024
22 checks passed
@twsouthwick twsouthwick deleted the save-part branch November 20, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling Worksheet.Save() makes rest of changes to worksheet not apply in 3.1
3 participants