Skip to content

Update System.IO.Packaging to 8.0.1 #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mikeebowen
Copy link
Collaborator

Copy link

Test Results

    70 files  ±0      70 suites  ±0   56m 49s ⏱️ -2s
 2 033 tests ±0   2 030 ✅ ±0   3 💤 ±0  0 ❌ ±0 
32 322 runs  ±0  32 286 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 6185f89. ± Comparison against base commit 29b0f44.

Copy link
Collaborator

@tomjebo tomjebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, this looks good.

@@ -2,7 +2,7 @@
<Project>
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.12" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.12" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like this line needed to change right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's removing the extra space after the element. It happened automatically with the update.

@@ -31,4 +31,4 @@
<PackageVersion Include="xunit" Version="2.9.1" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.1" />
</ItemGroup>
</Project>
</Project>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one also maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is adding a blank line at the end of the file.

@mikeebowen mikeebowen merged commit abe3f9c into dotnet:main Oct 11, 2024
22 checks passed
@mikeebowen mikeebowen deleted the update-system.io.packaging branch October 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.IO.Packaging version 8.0.0 transitive reference issue via DocumentFormat.OpenXml version 3.1.0 - CVE-2024-43483, CVE-2024-43484
3 participants