-
Notifications
You must be signed in to change notification settings - Fork 561
Update System.IO.Packaging to 8.0.1 #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikeebowen
commented
Oct 10, 2024
- closes System.IO.Packaging version 8.0.0 transitive reference issue via DocumentFormat.OpenXml version 3.1.0 - CVE-2024-43483, CVE-2024-43484 #1806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this looks good.
@@ -2,7 +2,7 @@ | |||
<Project> | |||
<ItemGroup> | |||
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" /> | |||
<PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.12" /> | |||
<PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.13.12" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like this line needed to change right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's removing the extra space after the element. It happened automatically with the update.
@@ -31,4 +31,4 @@ | |||
<PackageVersion Include="xunit" Version="2.9.1" /> | |||
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.1" /> | |||
</ItemGroup> | |||
</Project> | |||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one also maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is adding a blank line at the end of the file.