Office2021 #1030
Merged
Office2021 #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
reviewed
Sep 20, 2021
| @@ -245,6 +245,9 @@ private static string NormalizeNamespace(in OpenXmlNamespace ns) | |||
| { "http://schemas.microsoft.com/office/spreadsheetml/2014/11/main", "x16", FileFormatVersions.Office2016 }, | |||
| { "http://schemas.microsoft.com/office/spreadsheetml/2015/02/main", "x16r2", FileFormatVersions.Office2016 }, | |||
| { "http://schemas.microsoft.com/office/word/2015/wordml/symex", "w16se", FileFormatVersions.Office2016 }, | |||
| // Named 2013/main/command with "oac" ns prefix to avoid conflict with officedocument/2006/characteristics | |||
| { "http://schemas.microsoft.com/office/drawing/2013/main/command", "oac", FileFormatVersions.Office2016 }, | |||
There was a problem hiding this comment.
This is a new ns prefix and namespace added retro actively to 2016, 2019 and in 2021 to include moniker types that were not included a few years ago.
| @@ -454,7 +454,7 @@ public OfficeArtExtensionList(string outerXml) : base(outerXml) | |||
| internal override void ConfigureMetadata(ElementMetadata.Builder builder) | |||
| { | |||
| base.ConfigureMetadata(builder); | |||
| builder.SetSchema(112, "extLst"); | |||
| builder.SetSchema(114, "extLst"); | |||
There was a problem hiding this comment.
Have you done the back and forth for this? We should really switch it out to use the proper schemas
There was a problem hiding this comment.
these were offset by retroactive introduction of the moniker types for drawing. I don't think they'll impact the public API surface or at least with any breaking change.
twsouthwick
previously approved these changes
Sep 20, 2021
AlfredHellstern
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Office 2021 updated types:
Label Information part support
PowerPoint Comments support
Excel Named Sheet Views support
Excel Rich Data enhancements
Word Comments Extensibilty part types
Document Tasks support in Word
Drawing Sketchy Shapes support